fix(auth): handle credentials not found error during login validation #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login command now properly handles CredentialsNotFoundError exceptions during credential validation. Previously, when no credentials existed, the validation would fail and prevent users from logging in. This change adds specific exception handling to allow the login process to proceed when no credentials are found. Additionally, the CredentialsManager.validate() method now raises CredentialsNotFoundError with a descriptive error message instead of returning an invalid ValidationResult when no credentials exist. This provides better error handling consistency across the codebase. Comprehensive tests have been added to verify the new behavior, including scenarios with no existing credentials, existing valid credentials, and various error conditions.
CaddyGlow
approved these changes
Sep 4, 2025
Owner
CaddyGlow
left a comment
CaddyGlow
left a comment
There was a problem hiding this comment.
Thanks for your patience! The merge will happen. FYI, I'll be releasing v0.2 soon. This version will be plugin-based, making it much easier to add new providers in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login command now properly handles CredentialsNotFoundError exceptions during credential validation. Previously, when no credentials existed, the validation would fail and prevent users from logging in.
This change adds specific exception handling to allow the login process to proceed when no credentials are found.
Additionally, the CredentialsManager.validate() method now raises CredentialsNotFoundError with a descriptive error message instead of returning an invalid ValidationResult when no credentials exist. This provides better error handling consistency across the codebase.
Comprehensive tests have been added to verify the new behavior, including scenarios with no existing credentials, existing valid credentials, and various error conditions.